-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix member option appear in transaction thread report detail page #42036
Conversation
src/libs/ReportUtils.ts
Outdated
@@ -1499,6 +1499,10 @@ function canAddOrDeleteTransactions(moneyRequestReport: OnyxEntry<Report>): bool | |||
return false; | |||
} | |||
|
|||
if (moneyRequestReport?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkdengineer Why do we need this change?
src/libs/ReportUtils.ts
Outdated
@@ -1217,7 +1225,7 @@ function hasExpenses(reportID?: string): boolean { | |||
* Whether the provided report is a closed expense report with no expenses | |||
*/ | |||
function isClosedExpenseReportWithNoExpenses(report: OnyxEntry<Report>): boolean { | |||
return report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && isExpenseReport(report) && !hasExpenses(report.reportID); | |||
return report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED && isMoneyRequestReport(report) && !hasExpenses(report.reportID); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same doubt, why this change?
@Pujan92 Missed to remove the change that I added in another PR. I updated to remove it. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativepm2.webmAndroid: mWeb Chromepm1.webmiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-17.at.01.24.33.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-17.at.01.27.09.mp4MacOS: Chrome / SafariScreen.Recording.2024-05-16.at.17.59.53.movMacOS: DesktopScreen.Recording.2024-05-17.at.01.51.44.mov |
@nkdengineer I don't think we need to create 2 transactions to reproduce, can you plz update the test steps by considering any expense submission? |
@nkdengineer I am still able to reproduce the issue for the first transaction with the new user, also you can create the expense offline to verify it better. Could you plz check and fix this? Screen.Recording.2024-05-14.at.18.54.02.mov |
@Pujan92 Because the bug happens in transaction thread report so we need create at least two requests to open the transaction thread easiest. If not we need open the transaction thread report via deep link.
For the first transaction, the report in the video is the IOU report which is called as combine report if we only have one transaction. The RCA is participant here is wrong. I updated to fix this case. Lines 3599 to 3600 in 76846da
|
[payeeAccountID]: {hidden: false}, | ||
[payerAccountID]: {hidden: false}, | ||
[payeeAccountID]: {hidden: true}, | ||
[payerAccountID]: {hidden: true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially thought here we should also set hidden value based on some flag as buildOptimisticIOUReport
called from multiple flows but seems not needed and this works fine.
@nkdengineer Please merge main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tagging @rlinoz as they aren't assigned automatically(might be due to merge freeze) |
@rlinoz Can we merge this now? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.77-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
|
Details
Fix member option appear in transaction thread report detail page
Fixed Issues
$ #41832
PROPOSAL: #41832 (comment)
Tests
Members
option doesn't appearOffline tests
Same as above
QA Steps
Members
option doesn't appearPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-05-13.at.11.57.15.mov
Android: mWeb Chrome
Screen.Recording.2024-05-13.at.11.54.35.mov
iOS: Native
Screen.Recording.2024-05-13.at.11.56.47.mov
iOS: mWeb Safari
Screen.Recording.2024-05-13.at.11.55.23.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-13.at.11.53.00.mov
MacOS: Desktop
Screen.Recording.2024-05-13.at.11.58.50.mov